Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "as" completion for imports #95

Conversation

felixrieg
Copy link
Collaborator

Fixes: #92

Adds "as" completion suggestion to imports for aliasing.

@felixrieg felixrieg requested a review from ThiBruUU October 2, 2023 07:10
Copy link
Collaborator

@ThiBruUU ThiBruUU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected

@SundermannC
Copy link
Member

For me, it does not seem to work. I use autocomplete (ctrl + space) after specifying the imported uvl model as seen below:
image
Do you have an idea what might be issue? @felixrieg

@felixrieg
Copy link
Collaborator Author

this import with a dot is giving a weird behaviour to the completionEnv. I can add it, but then the "as" keyword could also appear in other circumstances.

@SundermannC
Copy link
Member

Works as expected now. Thanks a lot!

@SundermannC SundermannC merged commit b8789aa into Universal-Variability-Language:master Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete is not suggesting as for aliases
3 participants