Skip to content

Added comment box option when creating a new area/point/polygon #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 12, 2021

Conversation

erobaina
Copy link

@erobaina erobaina commented Jan 28, 2021

Description

Added the ability to pass a prop that will determine whether to show a comment box or not.
After you hit the Save button, the comment will be part of that region object.

@seveibar
Copy link
Contributor

hey @erobaina thanks for the PR :) it looks pretty good but I'm going to run a test manually. We don't use the package-lock.json file (we use yarn.lock), can you remove that file?

@seveibar
Copy link
Contributor

nvm it turns out i can :)

@@ -1,6 +1,6 @@
// @flow

import React, { useState, memo } from "react"
import React, { useRef, memo } from "react"
import Paper from "@material-ui/core/Paper"
import { makeStyles } from "@material-ui/core/styles"
import styles from "./styles"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to import TextField (it doesn't compile?)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seveibar
That's right, sorry I missed that

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't compile 😢

@erobaina
Copy link
Author

doesn't compile 😢

Just pushed a new commit with the import, good catch! Thank you

@seveibar
Copy link
Contributor

See how you have a merge commit? You can avoid that and keep a cleaner git history by doing git pull --rebase, then it'll apply your changes on top of the existing stuff :)

@seveibar
Copy link
Contributor

Hmm where's the comment box?
image

@erobaina
Copy link
Author

Hmm where's the comment box?
image
@seveibar
Sorry about that, I missed passing one prop, now it should work

Screen Shot 2021-01-29 at 15 50 36

@erobaina erobaina requested a review from seveibar February 3, 2021 14:41
@seveibar seveibar merged commit 03e0734 into UniversalDataTool:master Feb 12, 2021
seveibar pushed a commit that referenced this pull request Feb 12, 2021
# [1.8.0](v1.7.12...v1.8.0) (2021-02-12)

### Bug Fixes

* Merge pull request [#134](#134) from erobaina/master ([03e0734](03e0734))

### Features

* Merge pull request [#135](#135) from sreevardhanreddi/master ([5e05674](5e05674))
@seveibar
Copy link
Contributor

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants