-
Notifications
You must be signed in to change notification settings - Fork 181
Added comment box option when creating a new area/point/polygon #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hey @erobaina thanks for the PR :) it looks pretty good but I'm going to run a test manually. We don't use the |
nvm it turns out i can :) |
@@ -1,6 +1,6 @@ | |||
// @flow | |||
|
|||
import React, { useState, memo } from "react" | |||
import React, { useRef, memo } from "react" | |||
import Paper from "@material-ui/core/Paper" | |||
import { makeStyles } from "@material-ui/core/styles" | |||
import styles from "./styles" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to import TextField (it doesn't compile?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seveibar
That's right, sorry I missed that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't compile 😢
Just pushed a new commit with the import, good catch! Thank you |
See how you have a merge commit? You can avoid that and keep a cleaner git history by doing |
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Added the ability to pass a prop that will determine whether to show a comment box or not.
After you hit the Save button, the comment will be part of that region object.