Fix cases of PRON or DET lacks the PronType feature #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arademaker
reviewed
Oct 24, 2021
documents/CF0152.conllu
Outdated
| @@ -75,7 +75,7 @@ | |||
| 4 muito muito ADV <quant>|ADV|@>A _ 5 advmod _ _ | |||
| 5 instrutivos instrutivo ADJ ADJ|M|P|@N< Gender=Masc|Number=Plur 3 amod _ SpaceAfter=No | |||
| 6 , , PUNCT PU|@PU _ 8 punct _ _ | |||
| 7 a a DET N|M|S|@ADVL> Gender=Masc|Number=Sing 8 det _ MWE=a_céu_aberto | |||
There was a problem hiding this comment.
este a me parece um pronome, se fosse artigo concordaria com o nome céu Masc+Sing. Peço desfazer a mudança e abrir um issue para discutirmos esta sentença com calma.
documents/CF0243.conllu
Outdated
| @@ -12,7 +12,7 @@ | |||
| 6 , , PUNCT PU|@PU _ 3 punct _ _ | |||
| 7 diante diante ADV ADV|@ADVL> _ 11 case _ MWE=diante_de|MWEPOS=ADP | |||
| 8 de de ADP PRP|@A< _ 7 fixed _ _ | |||
| 9 dezenas dezenas DET <quant>|DET|M|P|@>N Gender=Masc|Number=Plur 11 det _ _ | |||
There was a problem hiding this comment.
no corpus, temos outros tantos casos de dezenas/centenas, peço desfazer mudança e vamos abrir um issue para rever estes casos?
% awk '$3 ~ /dezena|centena$/ {print $2,$3,$4}' * | sort | uniq -c
1 Dezenas dezena DET
1 centena centena ADJ
1 centena centena NUM
10 centenas centena NOUN
4 centenas centena NUM
2 dezena dezena NUM
4 dezenas dezena DET
2 dezenas dezena NUM
2 dezenas dezena PRON
1 dezenas dezenas DET
documents/CP0061.conllu
Outdated
| @@ -159,7 +159,7 @@ | |||
| 40 recente recente ADJ ADJ|F|S|@>N Gender=Fem|Number=Sing 41 amod _ _ | |||
| 41 visita visita NOUN <np-def>|N|F|S|@P< Gender=Fem|Number=Sing 28 obl _ _ | |||
| 42 a a ADP <first-cjt>|PRP|@N< _ 46 case _ _ | |||
| 43 uma um DET <cjt>|<card>|NUM|F|S|@P< NumType=Card 46 det _ _ | |||
There was a problem hiding this comment.
também não estou muito certo desta analise e sugiro verificar se ja temos e/ou criar issue para discutirmos esta construção uma das X...
|
Correções feitas em 53fc24c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR relacionado ao issue #365, correção de casos simples, que não envolvem discussões abertas em outros issue. Feitas utilizando a documentação e análise de casos semelhantes no próprio Bosque.