Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start ursim #204

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fix start ursim #204

merged 2 commits into from
Jun 3, 2024

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented May 29, 2024

There seems to be a regression from #201 when no model is provided

@fmauch fmauch force-pushed the fix_start_ursim branch from 5a6031d to 96a0601 Compare May 29, 2024 19:01
fmauch added 2 commits May 29, 2024 21:52
* Run downstream tests for ICI
* Correctly name jobs
* Test Jazzy driver
@fmauch fmauch force-pushed the fix_start_ursim branch from 1edfb47 to a3bf810 Compare May 29, 2024 19:54
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.05%. Comparing base (d21a402) to head (a3bf810).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   72.05%   72.05%           
=======================================
  Files          71       71           
  Lines        2652     2652           
  Branches      337      337           
=======================================
  Hits         1911     1911           
  Misses        555      555           
  Partials      186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmauch fmauch marked this pull request as ready for review June 1, 2024 09:01
@fmauch fmauch requested a review from VinDp June 1, 2024 09:02
Copy link

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@VinDp VinDp merged commit 0a73cd1 into UniversalRobots:master Jun 3, 2024
24 checks passed
@fmauch fmauch deleted the fix_start_ursim branch June 3, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants