Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update game data for 7.15 #170

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

karashiiro
Copy link
Member

@karashiiro karashiiro commented Dec 20, 2024

Summary by CodeRabbit

  • New Features

    • Introduced multiple JSON files containing structured datasets for professions, items, and item kinds across various languages (Chinese, German, English, French, Japanese).
    • Each dataset includes unique identifiers and names, facilitating easy access and categorization of game-related data.
  • Bug Fixes

    • Corrected minor formatting issues, including the absence of newline characters at the end of some files.

@karashiiro karashiiro merged commit a4f7496 into Universalis-FFXIV:main Dec 20, 2024
0 of 2 checks passed
Copy link

coderabbitai bot commented Dec 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a comprehensive set of JSON files across multiple language directories (Chinese, German, English, French, and Japanese) for the MogboardExporter project. These files provide structured data mappings for game-related entities such as character classes, job classifications, item types, and specific item catalogs. Each language directory contains consistent JSON files with similar structures, including cjc.json (class/job catalog), isc.json (item subcategories), itemKinds.json (item type definitions), and iuc.json (unique item catalog).

Changes

File Path Change Summary
tools/MogboardExporter/MogboardExporter.CafeMaker/......datagame/chs/ Added JSON files for Chinese language: cjc.json (profession mappings), isc.json (item subcategories), itemKinds.json (item types), iuc.json (unique items)
tools/MogboardExporter/MogboardExporter/......datagame/de/ Added German language JSON files with similar structure: cjc.json, isc.json, itemKinds.json, iuc.json
tools/MogboardExporter/MogboardExporter/......datagame/en/ Added English language JSON files with equivalent data structures
tools/MogboardExporter/MogboardExporter/......datagame/fr/ Added French language JSON files with consistent data organization
tools/MogboardExporter/MogboardExporter/......datagame/ja/ Added Japanese language JSON files with similar content and structure

Poem

🐰 Data hops across the lands,
JSON rabbits with multilingual hands,
Mapping classes, items with care,
From Chinese to German, beyond compare!
A linguistic dance of code so bright,
Bringing game worlds to playful light! 🎮


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49301a7 and 45f9934.

📒 Files selected for processing (20)
  • tools/MogboardExporter/MogboardExporter.CafeMaker/......datagame/chs/cjc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter.CafeMaker/......datagame/chs/isc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter.CafeMaker/......datagame/chs/itemKinds.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter.CafeMaker/......datagame/chs/iuc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/de/cjc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/de/isc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/de/itemKinds.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/de/iuc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/en/cjc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/en/isc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/en/itemKinds.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/en/iuc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/fr/cjc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/fr/isc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/fr/itemKinds.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/fr/iuc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/ja/cjc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/ja/isc.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/ja/itemKinds.json (1 hunks)
  • tools/MogboardExporter/MogboardExporter/......datagame/ja/iuc.json (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@karashiiro karashiiro deleted the feat/7.15 branch December 20, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant