Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jobcespedes What a wonderful Ansible role with great code quality! Thanks a lot. It helped me a lot getting Mailman 3 up and running.
I struggled a bit with your defaults, especially since it was hard to change the default mailman-web (Postorius) admin user's email
root@localhost
afterwards, if that was forgotten to getting overwritten on deploy.Here's my changes:
mailman3_service_name
var tomailman3_server_name
which makes more sensemailman3_postfix_debconf_status
tomailman3_debconf_status
mailman-admin@YOURDOMAIN
instead ofchangeme@YOURDOMAIN
, since most tutorials recommend that$alias_maps
to Postfixlocal_recipient_maps
, so that we could use an alias e.g. forpostorius mailman-admin@YOURDOMAIN
DEFAULT_FROM_EMAIL
andSERVER_EMAIL
configurabledjango.contrib.admin
inINSTALLED_APPS
by default, as a Mailman 3 install without admin probably doesn't make much sense (and in my case errored out)django_mailman3.lib.auth.fedora
(which probably nobody ever wants)mailman3_configure_postfix
var to be able to only configure Postfix without installing it (for those who already use their own role to install Postfix)Hope you can merge this. It was tested on a fresh Debian Bullseye 11.5 install.
Cheers, Philip