Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for utf-8 chars on win #269

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Jan 7, 2025

https://linear.app/unleash/issue/2-3110/net-sdk-utf-8-scandinavian-character-issue

Adds support for flag names with valid UTF-8 characters like ø when running on Windows.

The test runs show how the new tests failed on the previous version but passed on the new one, after bumping Yggdrasil.

image

Fixes #268

Copy link
Collaborator

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, good job!

@nunogois nunogois requested a review from sighphyre January 7, 2025 12:15
@nunogois nunogois merged commit a36507d into main Jan 7, 2025
8 checks passed
@nunogois nunogois deleted the fix-win-support-utf-8-chars branch January 7, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Valid UTF-8 character in feature description-field crashes Unleash Client
2 participants