Skip to content

Commit

Permalink
chore: amend release generation (#226)
Browse files Browse the repository at this point in the history
  • Loading branch information
gastonfournier authored Nov 23, 2023
1 parent 4e8f5ad commit db65acb
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
10 changes: 4 additions & 6 deletions .github/workflows/release_changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Build changelog
id: github_release
uses: metcalfc/changelog-generator@v0.4.4
uses: metcalfc/changelog-generator@v4.2.0
with:
myToken: ${{ secrets.GITHUB_TOKEN }}
- name: Create release
uses: actions/create-release@v1
uses: ncipollo/release-action@v1
with:
tag_name: ${{ github.ref }}
release_name: ${{ github.ref }}
body: ${{ steps.github_release.outputs.changelog }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN}}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN}}
9 changes: 6 additions & 3 deletions src/test/java/io/getunleash/DefaultUnleashTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
import org.slf4j.LoggerFactory;

class DefaultUnleashTest {
Expand Down Expand Up @@ -254,9 +256,10 @@ public void synchronous_fetch_on_initialisation_fails_on_initialization() {
assertThat(readySubscriber.ready).isFalse();
}

@Test
public void synchronous_fetch_on_initialisation_fails_on_non_200_response() throws URISyntaxException {
mockUnleashAPI(401);
@ParameterizedTest
@ValueSource(ints = {401, 403, 404, 500})
public void synchronous_fetch_on_initialisation_fails_on_non_200_response(int code) throws URISyntaxException {
mockUnleashAPI(code);
IsReadyTestSubscriber readySubscriber = new IsReadyTestSubscriber();
UnleashConfig config =
UnleashConfig.builder()
Expand Down

0 comments on commit db65acb

Please sign in to comment.