feat: Handle dependent feature toggles #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chriswk
commented
Oct 12, 2023
chriswk
commented
- A new feature added in beta to Unleash 5.6. With dependent feature toggle you can configure parent-child relationships. This change makes the SDK evaluate according to the client specifications defined for this.
chriswk
requested review from
gastonfournier,
kwasniew,
sighphyre and
andreas-unleash
kwasniew
reviewed
Oct 12, 2023
| strategy.getName()); | ||
| } | ||
| // Dependent toggles, no point in evaluating child strategies if our dependencies are | ||
| // not enabled |
There was a problem hiding this comment.
not enabled -> not satisfied. satisfied may mean disabled or enabled depending on how we configure our dependencies
There was a problem hiding this comment.
Thanks, I'll update the comment
kwasniew
reviewed
Oct 12, 2023
| } | ||
| } | ||
| return new FeatureEvaluationResult(false, defaultVariant); | ||
| } | ||
| } | ||
|
|
||
| // | ||
| // Checks a feature's dependencies (if it has any |
kwasniew
reviewed
Oct 12, 2023
kwasniew
approved these changes
Oct 12, 2023
- A new feature added in beta to Unleash 5.6. With dependent feature toggle you can configure parent-child relationships. This change makes the SDK evaluate according to the client specifications defined for this.
chriswk
force-pushed
the
feat/dependentFeatures
branch
from
eee5074 to
86c0cb1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.