Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent failure count going below zero #222

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Nov 8, 2023

While testing this, we found that successful invocation reduced failure count below 0, this caused the backoff to not work as intended

@chriswk chriswk requested a review from gardleopard November 8, 2023 12:16
Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! We testet this against a sandbox instance as well.

@chriswk chriswk merged commit 57d45d7 into main Nov 8, 2023
4 checks passed
@chriswk chriswk deleted the task/addThrottleTestToPreventNegativeFailureCount branch November 8, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants