Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: experimental CLI docs #17

Merged
merged 7 commits into from
Feb 17, 2023
Merged

Docs: experimental CLI docs #17

merged 7 commits into from
Feb 17, 2023

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Feb 13, 2023

About the changes

Documentation for #16

@Tymek Tymek marked this pull request as ready for review February 14, 2023 11:21
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! This is very exciting 😄 Got some minor fixes and typos, plus one question that requires a little more work to address, I think.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😄 I'm still not sure about that one section, though 🤔

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a missing word that we should fix (my fault). Otherwise it looks fine to me, but the docs don't mention the shorthand options that they did previously. Is there a reason you took them out?

(I didn't include them in my example because I don't know what they do, but I don't think you responded to that question for more info?)

README.md Outdated Show resolved Hide resolved
Tymek and others added 7 commits February 17, 2023 11:33
Update README.md

Co-authored-by: Thomas Heartman <thomasheartman+github@gmail.com>
Co-authored-by: Thomas Heartman <thomasheartman+github@gmail.com>
Co-authored-by: Thomas Heartman <thomasheartman+github@gmail.com>
Co-authored-by: Thomas Heartman <thomasheartman+github@gmail.com>
@Tymek Tymek merged commit 38ac094 into main Feb 17, 2023
@Tymek Tymek deleted the docs/cli branch February 17, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants