Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose all flagsClient functions #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: expose all flagsClient functions #98

wants to merge 1 commit into from

Conversation

Netail
Copy link
Contributor

@Netail Netail commented Dec 23, 2024 •
edited
Loading

I mainly needed getAllToggles() from the flagsClient(), but there's much more, why not expose the full client instead of a selection of functions?

@gastonfournier gastonfournier requested a review from Tymek January 7, 2025 08:43
Tymek
Tymek approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@Tymek Tymek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a good change. But maybe what you're looking for is either getFrontendFlags, or just an output of evaluateFlags?

@Netail
Copy link
Contributor Author

Netail commented Jan 7, 2025

It looks like a good change. But maybe what you're looking for is either getFrontendFlags, or just an output of evaluateFlags?

Yeah I realised later on xd, but still not a bad idea to expose the full client I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tymek Tymek Tymek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Status: Approved PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Netail @Tymek