Feat: Global segments #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
sighphyre
reviewed
Aug 11, 2022
| $constraints = $strategy->getConstraints(); | ||
| $segments = method_exists($strategy, 'getSegments') ? $strategy->getSegments() : []; | ||
| foreach ($segments as $segment) { | ||
| $constraints = [...$constraints, ...$segment->getConstraints()]; |
There was a problem hiding this comment.
This looks to my very uninformed PHP eyes that this is unpacking each segment into the array in a loop. Is this an efficient way to do this? I'm mostly asking because we have folks that are wanting to use this feature to create very large segments and reuse them a lot
There was a problem hiding this comment.
You're right, that could be a little inefficient, don't know what I was thinking. I redid it to use yield and also got rid of one null check that wasn't necessary in each iteration.
There was a problem hiding this comment.
Hahaha, this is why we do code review, I do things like this all the time :)
Thank you! That looks great!
|
|
||
| /** | ||
| * This class is only for triggering code that doesn't really make sense to test and is here to achieve 100% code coverage. | ||
| * The reason is to catch potential problems during transpilation to lower versions of php. |
sighphyre
approved these changes
Aug 11, 2022
|
Yep, good to go, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Global segments
Fixes #103
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: