Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow psr/simple-cache 3.x #120

Merged
merged 4 commits into from
Oct 14, 2022

Conversation

colinodell
Copy link
Contributor

Description

Adds support for using this library with psr/simple-cache 2.x and 3.x without breaking backward-compatibility.

Closes #119

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Spec Tests
  • Integration tests / Manual Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor Author

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes to assist with your review :)

.github/workflows/tests.yaml Show resolved Hide resolved
phpstan.neon.dist Show resolved Hide resolved
tests/Traits/FakeCacheImplementationTrait.php Show resolved Hide resolved
tests/Traits/RealCacheImplementationTrait.php Show resolved Hide resolved
tests/UnleashBuilderTest.php Show resolved Hide resolved
@sighphyre
Copy link
Member

@colinodell This looks great! Thanks for doing this!

I'm happy with this but I'd like @RikudouSage to take a glance and give the nod

@sighphyre sighphyre requested a review from RikudouSage October 13, 2022 08:58
Copy link
Collaborator

@RikudouSage RikudouSage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! There's just one small thing and then I'm more than happy to merge!

phpstan.neon.dist Show resolved Hide resolved
@RikudouSage RikudouSage merged commit eee4a18 into Unleash:main Oct 14, 2022
@colinodell colinodell deleted the allow-psr-simple-cache-3 branch October 14, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Allow installation with psr/simple-cache 3.x
3 participants