Fix/ends with operator #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ends with the context property rather than the reverse
ivarconr
approved these changes
Jan 25, 2023
I hear you, at the same time this is a bug breaking expectations on how Unleash works. I would not be too worried as the intention is most likely it should be enabled in this case. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches the strEndsWith operator to check that constraint property ends with the context property rather than the reverse. The reason the client specifications were passing is because of a bug in that project (patched here: Unleash/client-specification#47).
strStartsWith is not affected, the check is correct here: https://github.com/Unleash/unleash-client-php/blob/main/src/ConstraintValidator/Operator/String/StringStartsWithOperatorValidator.php
We might want to think about what version we release this under. Technically it's a bug fix but there's a risk of having an automated bot upgrade the SDK because it sees a patch version and flipping a bunch of toggles in the wild.