Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions for doc publishing. #332

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Fix permissions for doc publishing. #332

merged 3 commits into from
Nov 20, 2024

Conversation

ivanklee86
Copy link
Collaborator

Description

Add permissions so doc release step will succeed!

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Spec Tests
  • Integration tests / Manual Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That simple? LGTM

@coveralls
Copy link

coveralls commented Nov 20, 2024

Coverage Status

coverage: 95.249%. remained the same
when pulling 76f76d3 on fix_doc_publishing
into bf41c6e on main.

@ivanklee86 ivanklee86 merged commit 6dfcec2 into main Nov 20, 2024
43 checks passed
@ivanklee86 ivanklee86 deleted the fix_doc_publishing branch November 20, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants