Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Make README a quickstart and move concept/benchmarking/deploying to separate files #475

Merged
merged 10 commits into from
Jul 4, 2024

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Jul 4, 2024

Start of the work with regards to making our README the one-stop shop to understand how to run Edge. Moving deployment, concepts, migration and other details into separate files to keep README concise and easy to read.

@chriswk chriswk requested review from nunogois and sighphyre July 4, 2024 09:25
@chriswk chriswk self-assigned this Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@chriswk chriswk marked this pull request as ready for review July 4, 2024 10:54
@@ -3,7 +3,7 @@
[![crates.io](https://img.shields.io/crates/v/unleash-edge?label=latest)](https://crates.io/crates/unleash-edge)
[![Documentation](https://docs.rs/unleash-edge/badge.svg?version=latest)](https://docs.rs/unleash-edge/latest)
![MIT licensed](https://img.shields.io/crates/l/unleash-edge.svg)
[![Dependency Status](https://deps.rs/crate/unleash-edge/19.1.3/status.svg)](https://deps.rs/crate/unleash-edge/19.1.3)
[![Dependency Status](https://deps.rs/crate/unleash-edge/19.2.0/status.svg)](https://deps.rs/crate/unleash-edge/19.2.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we need to manually update every time? If so, can we update <mostrecentversion> in our quickstart command below to be the latest version as well?

Ideally we would be able to automate both.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, Ideally we'd like to update this before cutting releases, that way the dependency banner matches the version it belongs to, rather than whenever we remembered to update it last.

I'd love to find a way to update this automatically based on most recent version.

@@ -0,0 +1,68 @@
# Benchmarking

## Performance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a redundant header?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. But I'm going to have another go at benchmarking now that we have better numbers for small/medium/large feature sets.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I'll leave it in place for this one.


## Development

See our [Contributors guide](./CONTRIBUTING.md) as well as our [development-guide](./development-guide.md)
See our [Contributors guide](../CONTRIBUTING.md) as well as our [development-guide](../development-guide.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: Is server/README.md a duplicate of the root README.md? Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, due to how we setup the workspace, it's server/README.md that gets published to crates.io, but README.md that is available on github/unleash docs.

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my comments are most likely out of scope for this PR and better suited for any following rewrites we do, so feel free to ignore them.

chriswk and others added 7 commits July 4, 2024 13:27
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
@chriswk chriswk merged commit 847d112 into main Jul 4, 2024
7 checks passed
@chriswk chriswk deleted the task/updateREADME branch July 4, 2024 12:01
gastonfournier added a commit to Unleash/unleash that referenced this pull request Aug 1, 2024
When all edge documentation was in a single page, we had all of it here:
https://docs.getunleash.io/reference/unleash-edge but after splitting up
Unleash/unleash-edge#475 some of that
documentation is not present in our docs and we should probably have
them as sub-pages

This change allows us to include subpages for external documentation.
Note that the key of the subpage needs to match the remote path

Checkout the preview:
https://unleash-docs-git-add-edge-subpages-unleash-team.vercel.app/

![image](https://github.com/user-attachments/assets/4b87fe25-fca6-4995-b296-aa58caab4f62)

---------

Co-authored-by: Thomas Heartman <thomas@getunleash.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants