Merge branch 'main' into feat/test-release-script

src/index.test.ts

@@ -1,9 +1,9 @@
 import { FetchMock } from 'jest-fetch-mock';
 import 'jest-localstorage-mock';
-import * as data from './tests/example-data.json';
+import * as data from './test/testdata.json';
 import IStorageProvider from './storage-provider';
 import { EVENTS, IConfig, IMutableContext, UnleashClient } from './index';
-import { getTypeSafeRequest, getTypeSafeRequestUrl } from './tests/util';
+import { getTypeSafeRequest, getTypeSafeRequestUrl } from './test';
 
 jest.useFakeTimers();
 

src/index.ts

@@ -164,6 +164,7 @@ export class UnleashClient extends TinyEmitter {
         this.bootstrapOverride = bootstrapOverride;
 
         this.metrics = new Metrics({
+            onError: this.emit.bind(this, EVENTS.ERROR),
             appName,
             metricsInterval,
             disableMetrics,

src/metrics.test.ts

@@ -1,6 +1,6 @@
 import { FetchMock } from 'jest-fetch-mock';
 import Metrics from './metrics';
-import { getTypeSafeRequest, parseRequestBodyWithType } from './tests/util';
+import { getTypeSafeRequest, parseRequestBodyWithType } from './test';
 
 jest.useFakeTimers();
 
@@ -13,6 +13,7 @@ afterEach(() => {
 
 test('should be disabled by flag disableMetrics', async () => {
     const metrics = new Metrics({
+        onError: console.error,
         appName: 'test',
         metricsInterval: 0,
         disableMetrics: true,
@@ -31,6 +32,7 @@ test('should be disabled by flag disableMetrics', async () => {
 
 test('should send metrics', async () => {
     const metrics = new Metrics({
+        onError: console.error,
         appName: 'test',
         metricsInterval: 0,
         disableMetrics: false,
@@ -62,6 +64,7 @@ test('should send metrics', async () => {
 
 test('should send metrics under custom header', async () => {
     const metrics = new Metrics({
+        onError: console.error,
         appName: 'test',
         metricsInterval: 0,
         disableMetrics: false,
@@ -84,6 +87,7 @@ test('should send metrics under custom header', async () => {
 
 test('Should send initial metrics after 2 seconds', () => {
     const metrics = new Metrics({
+        onError: console.error,
         appName: 'test',
         metricsInterval: 5,
         disableMetrics: false,
@@ -106,6 +110,7 @@ test('Should send initial metrics after 2 seconds', () => {
 
 test('should send metrics based on timer interval', async () => {
     const metrics = new Metrics({
+        onError: console.error,
         appName: 'test',
         metricsInterval: 5,
         disableMetrics: false,

src/metrics.ts

@@ -1,5 +1,7 @@
 // Simplified version of: https://github.com/Unleash/unleash-client-node/blob/main/src/metrics.ts
+
 export interface MetricsOptions {
+    onError: OnError;
     appName: string;
     metricsInterval: number;
     disableMetrics?: boolean;
@@ -21,7 +23,10 @@ interface Payload {
     instanceId: string;
 }
 
+type OnError = (error: unknown) => void;
+
 export default class Metrics {
+    private onError: OnError;
     private bucket: Bucket;
     private appName: string;
     private metricsInterval: number;
@@ -33,6 +38,7 @@ export default class Metrics {
     private headerName: string;
 
     constructor({
+        onError,
         appName,
         metricsInterval,
         disableMetrics = false,
@@ -41,6 +47,7 @@ export default class Metrics {
         fetch,
         headerName,
     }: MetricsOptions) {
+        this.onError = onError;
         this.disabled = disableMetrics;
         this.metricsInterval = metricsInterval * 1000;
         this.appName = appName;
@@ -93,16 +100,21 @@ export default class Metrics {
             return;
         }
 
-        await this.fetch(url, {
-            cache: 'no-cache',
-            method: 'POST',
-            headers: {
-                [this.headerName]: this.clientKey,
-                Accept: 'application/json',
-                'Content-Type': 'application/json',
-            },
-            body: JSON.stringify(payload),
-        });
+        try {
+            await this.fetch(url, {
+                cache: 'no-cache',
+                method: 'POST',
+                headers: {
+                    [this.headerName]: this.clientKey,
+                    Accept: 'application/json',
+                    'Content-Type': 'application/json',
+                },
+                body: JSON.stringify(payload),
+            });
+        } catch (e) {
+            console.error('Unleash: unable to send feature metrics', e);
+            this.onError(e);
+        }
     }
 
     public count(name: string, enabled: boolean): boolean {

src/test/index.html

@@ -0,0 +1,27 @@
+<!DOCTYPE html>
+<html lang='en'>
+<head>
+    <meta charset='utf-8' />
+    <title>unleash-proxy-client-js manual test</title>
+    <script src='../../build/main.min.js' type='text/javascript'></script>
+    <script type='module'>
+        const client = new unleash.UnleashClient({
+            url: 'http://localhost:3000/proxy',
+            clientKey: 'a',
+            appName: 'a',
+            refreshInterval: 1,
+            metricsInterval: 1,
+            disableMetrics: false
+        });
+
+        client.start();
+        client.on('initialized', () => console.log('initialized'));
+        client.on('error', (error) => console.log('error', error));
+        client.on('ready', () => console.log('ready'));
+        client.on('impression', () => console.log('impression'));
+        client.on('update', () => console.log('update', client.isEnabled('a')));
+    </script>
+</head>
+<body>
+</body>
+</html>