chore(1-3230): use homebrew version of uuid generation #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one from the uuid library relies on an underlying crypto library which doesn't exist at least in certain GitHub runners and may also cause issues for react native applications. This impl sidesteps that issue.
kwasniew
reviewed
Jan 16, 2025
| @@ -1,5 +1,4 @@ | |||
| import { TinyEmitter } from 'tiny-emitter'; | |||
| import { v4 as uuidv4 } from 'uuid'; | |||
There was a problem hiding this comment.
do we use it for something else? can we remove this from package dependencies?
There was a problem hiding this comment.
Good point. I haven't checked, but I'm pretty sure I wasn't the one to add it. Let's see.
There was a problem hiding this comment.
We use it in src/events-handler.ts too. We could switch that one for the same impl potentially, but I don't really wanna touch that now if we don't have to?
kwasniew
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one from the uuid library relies on an underlying crypto library
which doesn't exist at least in certain GitHub runners and may also
cause issues for react native applications.
This impl sidesteps that issue.
The same uuid generation method that we're cutting out here is also being used in
src/events-handler.ts. However, because we haven't received any complaints about that, I'll leave it in.