Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Allow turning off proxy refresh #50

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Nov 30, 2021

After a meeting with customer that wanted the possibility to disable
refreshing, they only needed toggle status updated at startup.

This PR adds the possibility to not fetch via a new disableRefresh flag, or by setting refreshInterval to 0 the client will no longer perform refreshes.

After a meeting with customer that wanted the possibility to disable
refreshing, they only needed toggle status updated at startup
Copy link
Contributor

@ykhedher ykhedher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍.

@ivarconr
Copy link
Member

Nice, I would love to see the available option also documented in the available options section in the README.md:
https://github.com/Unleash/unleash-proxy-client-js#available-options

@chriswk
Copy link
Member Author

chriswk commented Dec 3, 2021

Will update the documentation before merging

@chriswk chriswk force-pushed the task/makeItPossibleToNotRefreshToggles branch from 9cecc2d to f674e99 Compare December 3, 2021 13:41
@chriswk chriswk merged commit cdb169c into master Dec 6, 2021
@chriswk chriswk deleted the task/makeItPossibleToNotRefreshToggles branch December 6, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants