Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional possibility to customize header for clientKey #58

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

Dzixxx
Copy link
Contributor

@Dzixxx Dzixxx commented Jan 4, 2022

According to Unleash/unleash-proxy#39 I'm providing possibility to specify proxy secret header name (client key) also from browser side :)

@ivarconr
Copy link
Member

ivarconr commented Jan 5, 2022

You will also have to change metrics.ts to use the correct headerName when posting metrics.

@Dzixxx
Copy link
Contributor Author

Dzixxx commented Jan 5, 2022

@ivarconr aligned, thank U! 😄

@ivarconr ivarconr self-requested a review January 5, 2022 20:05
@ivarconr ivarconr merged commit 42e02fb into Unleash:main Jan 5, 2022
@Dzixxx Dzixxx deleted the customHeader branch January 9, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants