BREAKING CHANGE: remove built-in support for react native async storage #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dzixxx
force-pushed
the
remove-react-native
branch
4 times, most recently
from
111b5f7
to
f1ab6ba
Compare
Dzixxx
changed the title
ivarconr
reviewed
Apr 6, 2022
| } catch (ex) { | ||
| console.error(ex); | ||
| } | ||
| } | ||
|
|
||
| public async get(name: string) { | ||
| public get(name: string) { |
There was a problem hiding this comment.
Even though we do not need async marker on this method i think I would prefer to have it, to make sure we remember to await the get method also, sense this will be the default implementation. I can easily see myself (or someone else) forgetting the "await" in the calling code, if this method is not marked as async in the default implementation. This will lead to bugs, only visible when using a custom store.
There was a problem hiding this comment.
Evening! No problem to get rid of async to but U've defined interface which is Promise based :)
// src/storage-provider.ts
export default interface IStorageProvider {
save: (name: string, data: any) => Promise<void>;
get: (name: string) => Promise<any>;
}
|
This looks really good. It will also make sense for us to push an update to the react SDK, after we release this one @FredrikOseberg ! |
Dzixxx
force-pushed
the
remove-react-native
branch
2 times, most recently
from
9166b98
to
382a326
Compare
|
(rebasing ☝️) |
Dzixxx
force-pushed
the
remove-react-native
branch
from
382a326
to
f58fc33
Compare
|
@ivarconr ping 😅 |
ivarconr
approved these changes
Apr 11, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Breaking Change] v2
Removing built-in support for react-native (will become optional as custom storageProvider provided by developer itself)
react-native-async-storagewhich fallbacks to window.localStorage I just used window.localStorageKind regards
Dziczek!