Remove event listeners on unmount in useFlag and useVariant #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredrikOseberg
approved these changes
Mar 3, 2023
Thank you very much for your quick response! |
|
@6uliver Thanks for the contribution! It's merged now and we're aiming to get the release out some time this week 🚀 Great work 🥇 |
|
Pre-released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
I discovered that the event listeners are not removed properly in useFlag and useVariant. The original author's intention was correct but a return statement were missing by a mistake. It can cause "Can't perform a React state update on an unmounted component." error and unallocated resources.
Closes #90
Important files
I wrote tests first to prove the error so you should start the review with the new tests. The fix is simple, I've just added the missing returns in the implementation.
Discussion points
In the test suites I moved the mockClear calls inside the beforeEach, I think it's better to call them before every tests.