Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly filter for to dates #8567

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Oct 29, 2024

This change fixes a bug in the event filter's to query parameter.

The problem was that in an attempt to make it inclusive, we also
stripped it of the IS: prefix, which meant it had no effect. This
change fixes that by first splitting the value, fixing only the
date (because we want it to include the entire day), and then joining
it back together.

This change fixes a bug in the event filter's `to` query parameter.

The problem was that in an attempt to make it inclusive, we also
striped it of the `IS:` prefix, which meant it had no effect. This
change fixes that by first splitting the value, fixing only the
date (because we want it to include the entire day), and then joining
it back together.
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 8:25am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 8:25am

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

This reverts commit 002151b.
@thomasheartman thomasheartman merged commit b276d5a into main Oct 29, 2024
7 checks passed
@thomasheartman thomasheartman deleted the fix/1-3035-fix-to-query-param-in-event-filter branch October 29, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants