-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un 116 + UN-115 testing.md seeders, factories, etc #10
base: main
Are you sure you want to change the base?
Conversation
if (!$platform) { | ||
return response()->json(['error' => 'No matching platform connection found'], 401); | ||
} | ||
return new PlatformConnectionResource($platform); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PThorpe92 in order to be able to return the requisite Provider Platform data (and Connection state) to the v.1 UI this needs to return the ConsumerProviderResource::collection
that was in the #3 request that you had integrated into your branch earlier when we collaborated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConsumerProviderResource?
The show
function you have in the link returns
public function show(ConsumerPlatform $consumerPlatform)
{
return ConsumerPlatformResource::make($consumerPlatform);
}
So because this is a show
function and you have specified the ID
in the URL, it should return a collection of all that consumer platforms connections? that does make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Additionally it gets the state
value of the Platform Connection and adds that to the json Provider Platform (for that particular Consumer Platform) response data
No description provided.