Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual & remote (HTTP) deployments through GitHub UI/API #147

Merged
merged 31 commits into from
Oct 17, 2020
Merged

Manual & remote (HTTP) deployments through GitHub UI/API #147

merged 31 commits into from
Oct 17, 2020

Conversation

Demmonius
Copy link
Collaborator

@Demmonius Demmonius commented Aug 19, 2020 •
edited by Vadorequest
Loading

https://app.asana.com/0/1136912812619441/1187144316166177

Allows to deploy a customer from the GitHub UI and from HTTP call to GitHub Actions.

The goal of this feature is to allow manual deployment of customers through GitHub UI, and through external HTTP calls.

See WORKFLOW_DISPATCH for advanced documentation.

Additionally, a few more improvements related to GHA have been done in this PR:

  • Improved documentation
  • Improved debugging experience, by splitting complex data processing into smaller parts and printing results to GHA logs
  • Identified a bug where multiple simultaneous builds from different branches might not use the proper URL to perform E2E/LH tests (not solved, TODO added)
  • Reduced LH min scores in staging to avoid marking the github build as failed (only production matters)
  • Improved Github comments, now specify commit ID and deployment url in all cases (makes it easier to follow what results was yielded by a particular commit)

Important note:

It is not possible to use the manual trigger through NRN, because the github workflows must exist in the "main" github branch. NRN main branch is the documentation branch, and doesn't contain code-related actions.

This particular feature is usable only when making one of the preset your main branch (when forking NRN).

The API endpoint is usable from NRN directly though.

See https://github.saobby.my.eu.orgmunity/t/cant-trigger-workflow-manually/121740/52

@github-actions
Copy link

❌  Deployment FAILED
Commit 2815707 failed to deploy to
click to see logs

@github-actions
Copy link

❌  Deployment FAILED
Commit d9ae4e9 failed to deploy to
click to see logs

@github-actions
Copy link

❌  Deployment FAILED
Commit 797dada failed to deploy to
click to see logs

@github-actions
Copy link

❌  Deployment FAILED
Commit bf06175 failed to deploy to
click to see logs

@github-actions
Copy link

❌  Deployment FAILED
Commit 357ae45 failed to deploy to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-4u0r0vy5q.vercel.app
click to see logs

@github-actions
Copy link

❌  Deployment FAILED
Commit 636dc0b failed to deploy to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-4t8ph91zc.vercel.app
click to see logs

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 74f774f successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-827kc9w61.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

Vadorequest
Vadorequest requested changes Sep 21, 2020
View reviewed changes
.github/WORKFLOW_DISPATCH.md Show resolved Hide resolved
.github/WORKFLOW_DISPATCH.md Show resolved Hide resolved
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 9252774 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-17uw1cq0p.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS

@github-actions
Copy link

✅  Deployment SUCCESS
Commit b2e6edc successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-m5121mpa3.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@Vadorequest
Copy link
Member

@Demmonius I believe I've fixed/understood everything that wasn't clear. Could you update the production workflow now? :)

@github-actions
Copy link

✅  Deployment SUCCESS
Commit e418e07 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-l13e6ayt0.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit b2e6edc successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c2-dn2a6l9n3.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c2-custom-ac.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit d158fc1 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-dwvz0ka77.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 8921156 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-87p6t2og5.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@Vadorequest
Add more info on commit messages (commit ID + deployment url) for bet…
ed670a4 
…ter understanding of what deployment/E2E failed/succeeded
@github-actions
Copy link

✅  E2E tests SUCCESS

@github-actions
Copy link

✅  Deployment SUCCESS
Commit ed670a4 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-btkq9fhw5.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit ed670a4 previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-btkq9fhw5.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 55eb626 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-ucv6s8fdo.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

❌  E2E tests FAILED for commit 55eb626 previously deployed at
Download artifacts (screenshots + videos) from checks section

@github-actions
Copy link

❌  E2E tests FAILED
Download artifacts (screenshots + videos) from checks section

@github-actions
Copy link

✅  Deployment SUCCESS
Commit a2b1d89 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-dp11f2oms.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit a2b1d89 previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-dp11f2oms.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 7487bf2 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-krtini1ld.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

❌  E2E tests FAILED for commit 7487bf2 previously deployed at https://
Download artifacts (screenshots + videos) from checks section

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 73a80dc successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-8u1pct1z7.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

❌  E2E tests FAILED for commit 73a80dc previously deployed at https://
Download artifacts (screenshots + videos) from checks section

@github-actions
Copy link

✅  Deployment SUCCESS
Commit b73e68c successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-mqofy66q2.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

❌  E2E tests FAILED for commit b73e68c previously deployed at https://
Download artifacts (screenshots + videos) from checks section

@github-actions
Copy link

✅  Deployment SUCCESS
Commit dbfd4f8 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-n9ru06e1q.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

❌  E2E tests FAILED for commit dbfd4f8 previously deployed at https://
Download artifacts (screenshots + videos) from checks section

@Vadorequest Vadorequest force-pushed the custom-actions-trigger branch from dbfd4f8 to a2b1d89 Compare October 17, 2020 13:33
@github-actions
Copy link

✅  Deployment SUCCESS
Commit a2b1d89 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-dp11f2oms.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-custom-ac.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit a2b1d89 previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-n9ru06e1q.vercel.app

@Vadorequest Vadorequest merged commit e9c9afe into v2-mst-aptd-gcms-lcz-sty Oct 17, 2020
@Vadorequest Vadorequest deleted the custom-actions-trigger branch October 17, 2020 13:41
Vadorequest added a commit that referenced this pull request Oct 17, 2020
@Demmonius @Vadorequest
Manual & remote (HTTP) deployments through GitHub UI/API (#147)
776818c 
Co-authored-by: Dhenain Ambroise <ambroise.dhenain@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vadorequest Vadorequest Awaiting requested review from Vadorequest

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Demmonius @Vadorequest