Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added csstype for better typing experience #172

Merged
merged 3 commits into from
Sep 25, 2020
Merged

Added csstype for better typing experience #172

merged 3 commits into from
Sep 25, 2020

Conversation

samuelcastro
Copy link
Contributor

No description provided.

@samuelcastro samuelcastro mentioned this pull request Sep 24, 2020
Closed
Vadorequest
Vadorequest requested changes Sep 25, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/components/assets/GraphCMSAsset.test.tsx Outdated Show resolved Hide resolved
@Vadorequest
Copy link
Member

@samuelcastro Thanks! I added a few comments above :)

@Vadorequest
Copy link
Member

Thanks!

@Vadorequest Vadorequest merged commit 90c4b4e into UnlyEd:v2-mst-aptd-gcms-lcz-sty Sep 25, 2020
Vadorequest pushed a commit that referenced this pull request Sep 25, 2020
@samuelcastro @Vadorequest
Added csstype for better typing experience (#172)
2eaa607
@samuelcastro samuelcastro deleted the csstype branch September 25, 2020 20:34
@Vadorequest
Copy link
Member

@samuelcastro Funnily enough, I encounter more issues with that new typing.

TS2322: Type '{ alignContent: string; alignItems: string; alignSelf: string; animationDelay: string; animationDirection: string; animationDuration: string; animationFillMode: string; animationIterationCount: string | number; ... 750 more ...; vectorEffect: VectorEffectProperty; }' is not assignable to type 'CSSProperties'.   Types of property 'appearance' are incompatible.     Type 'AppearanceProperty' is not assignable to type 'Appearance'.       Type '"button-bevel"' is not assignable to type 'Appearance'.

Etc. Ran into half a dozen of issues, while the former code was working fine.

@samuelcastro
Copy link
Contributor Author

Nooo, how to reproduce?

@Vadorequest
Copy link
Member

I went back to the current code and the error doesn't show anymore. 🤷

Maybe a TS sync issue, I really don't get it. If I reproduce it I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vadorequest Vadorequest Vadorequest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelcastro @Vadorequest