Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 404 page generation + refactor all layouts SSG/SSR #346

Merged
merged 10 commits into from
May 28, 2021
Merged

Fix 404 page generation + refactor all layouts SSG/SSR #346

merged 10 commits into from
May 28, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented May 28, 2021 •
edited
Loading

The 404 page is failing in some edge cases, when it tries to redirect to 404 while building the 404 page itself.

Using a new and more modular way to use getStaticPaths/getStaticProps/getServerSideProps. (better composition)

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 15a3ac3 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-hzcsy59cx-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-404-build.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 15a3ac3 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-hzcsy59cx-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 28, 2021 20:02 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit f2bdbad successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-r551y7q8b-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-404-build.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit f2bdbad previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-r551y7q8b-unly-oss.vercel.app

@github-actions github-actions bot had a problem deploying to customer1-staging May 28, 2021 20:39 Failure
@github-actions
Copy link

❌  Deployment FAILED
Commit ee74f3f failed to deploy to
click to see logs

@github-actions github-actions bot temporarily deployed to customer1-staging May 28, 2021 20:47 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 8ecce99 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-3vqw9bv9x-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-404-build.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 8ecce99 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-3vqw9bv9x-unly-oss.vercel.app

@Vadorequest
Convert getPublicStaticPaths/getPublicStaticProps/getPublicServerSide…
c94a851 
…Props to functions returning a function (more flexible)
@github-actions github-actions bot temporarily deployed to customer1-staging May 28, 2021 21:00 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit c94a851 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-9yzyum9mz-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-404-build.vercel.app

@Vadorequest Vadorequest marked this pull request as ready for review May 28, 2021 21:11
@github-actions
Copy link

✅  E2E tests SUCCESS for commit c94a851 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-9yzyum9mz-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 28, 2021 21:20 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging May 28, 2021 21:23 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 8f86bc4 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-cirhlr4ll-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-404-build.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit d4bebcd successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-cqkepklcu-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-404-build.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 8f86bc4 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-cirhlr4ll-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 28, 2021 21:36 Inactive
@github-actions
Copy link

✅  E2E tests SUCCESS for commit d4bebcd previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-cqkepklcu-unly-oss.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 0ce029f successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-jz01nr593-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-404-build.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 28, 2021 21:44 Inactive
@Vadorequest Vadorequest changed the title Fix 404 page generation Fix 404 page generation + refactor all layouts SSG/SSR May 28, 2021
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 2b0b8ae successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-mnywdft8i-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-fix-404-build.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 0ce029f previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-jz01nr593-unly-oss.vercel.app

@Vadorequest Vadorequest merged commit c7b0165 into v2-mst-aptd-at-lcz-sty May 28, 2021
@Vadorequest Vadorequest deleted the fix-404-build branch May 28, 2021 21:53
@Vadorequest Vadorequest restored the fix-404-build branch May 28, 2021 21:53
@github-actions github-actions bot temporarily deployed to customer1-staging May 28, 2021 21:53 Inactive
@github-actions
Copy link

✅  E2E tests SUCCESS for commit 2b0b8ae previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-mnywdft8i-unly-oss.vercel.app

@Vadorequest Vadorequest deleted the fix-404-build branch May 28, 2021 22:01
@Vadorequest Vadorequest mentioned this pull request May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vadorequest