Update DataTables package in preparation of dark theme #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Smith <espadav8@gmail.com>
EspadaV8
force-pushed
the
update-datatables-package
branch
from
d2fd489 to
b19e1a4
Compare
|
Im pretty excited about updates to this plugin. Not being a front-end guy myself, I'd really appreciate updates like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on adding dark theme support for the data panel plugin. Part of that requires updating DataTables to 1.13 where they added support for dark mode
I didn't want to do all the updates at once, since the MR would be huge, so I'm breaking it down into smaller MRs. Part 1 of that is to just update the DataTables package.
I've tested it using my own plugin repo, and the UI is basically the same as it was previously.