Add dark theme support to File Size Metrics plugin #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Smith <espadav8@gmail.com>
|
Ah, one thing I missed in the screenshots, the table footer in the current dark theme looks like this
With the update it's actually visible
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial dark mode support for the File Size Metrics plugin.
It doesn't respond to toggling the theme, because its an iframe and the theme is passed in as a query string parameter, so I don't believe that'll be possible without forcing it to reload.
For now this just moves the CSS out into its own file (because it's getting long) and then moves a lot of the colours to use
var(...)syntax which is set in either alightordarkclass that is added to thehtmltag. This is done with a little bit of JS as high up the document as possible, to try and reduce any colour flickering (the JS just checks for the query param and then replaceslightwithdarkon thehtmltag).The SVGs don't respect the theme at the moment, but I am having a look into this to see what can be done.