Update metric charts to support dark mode #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Smith <espadav8@gmail.com>
Signed-off-by: Andrew Smith <espadav8@gmail.com>
Signed-off-by: Andrew Smith <espadav8@gmail.com>
Signed-off-by: Andrew Smith <espadav8@gmail.com>
EspadaV8
force-pushed
the
update-metric-charts-to-support-dark-mode
branch
from
17e2f74 to
2f44bbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the charting library to use the CSS variables that are defined on the page.
As part of the updates I've changed the colours to use the
--q-positiveand--q-negativethat are defined on the main pages. This means the blue bars are now green if there has been a reduction in the file size.