Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #311

Closed
wants to merge 1 commit into from
Closed

Update Dockerfile #311

wants to merge 1 commit into from

Conversation

apo-mak
Copy link

@apo-mak apo-mak commented Mar 12, 2022

Update "JELLYFIN_FFMPEG_VERSION" to a version that add support for :
"Add oneVPL runtime for QSV on 12th Gen Intel processors"

Pull request

CLA

  • I agree that by opening a pull requests I am handing over copyright ownership
    of my work contained in that pull request to the Unmanic project and the project
    owner. My contribution will become licensed under the same license as the overall project.
    This extends upon paragraph 11 of the Terms & Conditions stipulated in the GPL v3.0

Checklist

  • I have ensured that my pull request is being opened to merge into the staging branch.

  • I have ensured that all new python file contributions contain the correct header as
    stipulated in the Contributing Docs.

Description of the pull request

Update "JELLYFIN_FFMPEG_VERSION" to a version that add support for :
"Add oneVPL runtime for QSV on 12th Gen Intel processors"

Update "JELLYFIN_FFMPEG_VERSION"  to a version that add support for :
"Add oneVPL runtime for QSV on 12th Gen Intel processors"
@Josh5
Copy link
Collaborator

Josh5 commented Mar 14, 2022

Do you know if this update affects older Intel CPUs? Last time I updated I rolled it back because other users were unable to use vaapi on their installs that had previously been working.

@apo-mak
Copy link
Author

apo-mak commented Mar 16, 2022

I try it in my system (VM) with a xeon E5540 but not totally sure because it is a hyper-v setup and the cpu is virtualized and some times this crates a compatibility layer and dose not directly pass the cpu .

@Josh5
Copy link
Collaborator

Josh5 commented Mar 17, 2022

I would love to do some in-depth testing of this before it gets rolled out to everyone. I'll run some tests on my CPU, but it will probably work. The ones that had issues were the Intel Celeron CPUs that most people using Unmanic on a NAS have.

In the meantime, did you know that you can add startup scripts to the container that get executed when the container starts.
You could add this to it just for your setup.
It would be something like:

#      _      _ _        __ _         _____ _____
#     | | ___| | |_   _ / _(_)_ __   |  ___|  ___| __ ___  _ __   ___  __ _
#  _  | |/ _ \ | | | | | |_| | '_ \  | |_  | |_ | '_ ` _ \| '_ \ / _ \/ _` |
# | |_| |  __/ | | |_| |  _| | | | | |  _| |  _|| | | | | | |_) |  __/ (_| |
#  \___/ \___|_|_|\__, |_| |_|_| |_| |_|   |_|  |_| |_| |_| .__/ \___|\__, |
#                 |___/                                   |_|         |___/
#
JELLYFIN_FFMPEG_VERSION="4.4.1-3"

if [[ ! -f /config/jellyfin-ffmpeg_${JELLYFIN_FFMPEG_VERSION}-focal_amd64.deb ]]; then
    curl -ksL -o /config/jellyfin-ffmpeg_${JELLYFIN_FFMPEG_VERSION}-focal_amd64.deb \
        "https://repo.jellyfin.org/releases/server/ubuntu/versions/jellyfin-ffmpeg/${JELLYFIN_FFMPEG_VERSION}/jellyfin-ffmpeg_${JELLYFIN_FFMPEG_VERSION}-focal_amd64.deb"
fi

# Install updated jellyfin if version does not match
current_version=$(dpkg -s jellyfin-ffmpeg | grep '^Version:' | awk '{print $2}')
if [[ ${current_version} != "${JELLYFIN_FFMPEG_VERSION}-focal" ]]; then
    apt-get install -y /config/jellyfin-ffmpeg_${JELLYFIN_FFMPEG_VERSION}-focal_amd64.deb
fi

Similar to how Filebot is installed in the container in this guide: https://docs.unmanic.app/docs/guides/filebot_post_processor

@martadinata666
Copy link
Contributor

For references this thread specifically call out about the transcoding issue with older hardware, older than gen 8
jellyfin/jellyfin-ffmpeg#99

The solution it get is to specifically set LIBVA type to environment, as by default it use newer iHD instead i965
jellyfin/jellyfin#7397

Can't really tell if it work on container ENV.

@Josh5
Copy link
Collaborator

Josh5 commented Feb 25, 2024

After some internal testing, we have just bumped ffmpeg to v6

@Josh5 Josh5 closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants