fix crash when folder watcher fails #251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug provided in #248.
What happens: When the app starts it initializes an fsnotify structure, but if no folders are defined it does not use it. If this initialization fails, for any reason, the app now has an uninitialized data structure and later crashes when it tries to read it. The bug discovered shows a failure in this initialization due to
too many open files
. Never seen this, and this bug has never been brought up until now.So, to fix it, I did two things.
too many open files
problem.