fix: fix bugs in layoutelements #393

badGarnet · 2024-10-15T18:40:51Z

This PR fixes two bugs:

fix a type casting issue when subtracting a int array with a float. This popped up when testing with unstructured, and some sources of element coordinates are of int type. This PR adds a new unit test case for int coord type with the grouping function
fix element class id 0 becomes None bug: this happens when dumping LayoutElements as a list of LayoutElement. When an element class id is 0 the logic on main would treat it as no existing and use None as the type.

- fix eq override - use default factory to ensure element id mapping is always dict

christinestraub

LGTM!

badGarnet added 7 commits October 15, 2024 13:29

fix: fix element class id 0 becomes None bug

2b0f2d1

update changelog and bump version

74bb42b

fix line length

e97dd4a

fix: lint

df1c82f

fix: more type dealing with none vs nan

933dfd4

fix lint

d752755

- fix eq override - use default factory to ensure element id mapping is always dict

test: add test to different coord data types

9a27066

badGarnet requested review from qued and christinestraub October 16, 2024 15:57

christinestraub approved these changes Oct 16, 2024

View reviewed changes

badGarnet merged commit c53866b into main Oct 16, 2024
5 checks passed

badGarnet deleted the fix/incorrect-type-mixing branch October 16, 2024 18:16

Provide feedback