Jj/klaijan/csv #200
Draft
Jj/klaijan/csv #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coniferish
commented
Oct 25, 2024
| @@ -106,6 +107,7 @@ examples: | |||
| responses: | |||
| "200": | |||
| application/json: [{"type": "Title", "element_id": "6aa0ff22f91bbe7e26e8e25ca8052acd", "text": "LayoutParser: A Unified Toolkit for Deep Learning Based Document Image Analysis", "metadata": {"languages": ["eng"], "page_number": 1, "filename": "layout-parser-paper.pdf", "filetype": "application/pdf"}}] | |||
| text/csv: "<value>" | |||
There was a problem hiding this comment.
TODO: Figure out how to get the example from the openapi spec in here
Coniferish
commented
Oct 25, 2024
| @@ -8,4 +8,5 @@ | |||
| | `content_type` | *str* | :heavy_check_mark: | HTTP response content type for this operation | | |||
| | `status_code` | *int* | :heavy_check_mark: | HTTP response status code for this operation | | |||
| | `raw_response` | [httpx.Response](https://www.python-httpx.org/api/#response) | :heavy_check_mark: | Raw HTTP response; suitable for custom response parsing | | |||
| | `csv_elements` | *Optional[str]* | :heavy_minus_sign: | Successful Response | | |||
| | `elements` | List[Dict[str, *Any*]] | :heavy_minus_sign: | Successful Response | | |||
There was a problem hiding this comment.
Q: elements isn't displayed as optional, but response.elements is None when csv_elements is returned.
Coniferish
commented
Oct 25, 2024
| @@ -74,6 +74,8 @@ class PartitionResponseTypedDict(TypedDict): | |||
| r"""HTTP response status code for this operation""" | |||
| raw_response: httpx.Response | |||
| r"""Raw HTTP response; suitable for custom response parsing""" | |||
| csv_elements: NotRequired[str] | |||
| r"""Successful Response""" | |||
| elements: NotRequired[List[Dict[str, Any]]] | |||
| r"""Successful Response""" | |||
|
|
|||
There was a problem hiding this comment.
NTS: elements is listed as NotRequired/Optional
Coniferish
force-pushed
the
jj/klaijan/csv
branch
from
99a4172 to
033bf6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return text/csv when
output_format=OutputFormat.TEXT_CSV