remove abstract decorator from initialize in BaseEmbeddingEncoder

[mattseddon]

Closes #3731. Please see the issue for details.

Comments inline.

[mattseddon]

Matches the implementation of BaseEmbeddingEncoder in unstructured_ingest: https://github.com/Unstructured-IO/unstructured-ingest/blob/main/unstructured_ingest/embed/interfaces.py#L16

[mattseddon]

@MKhalusova, can you help me get this reviewed?... please 🙏🏻🙏🏻🙏🏻. The DataChain unstructured examples (here and here) are currently stuck on an older version of Unstructured because of #3731 and this change should close that issue.

[mattseddon]

@cragwolfe would this 👇🏻 be the correct format for the changelog entry?

0.16.5-dev0

Enhancements

Features

Fixes

• Remove abstract decorator from initialize in BaseEmbeddingEncoder

[MKhalusova]

@scanny Cam you please take a look?

[scanny]

@rbiseck3 Hi Roman, can you take a look at this one-liner? I think you were closer to the choices on this one. I'm not sure whether this is the right fix or whether HuggingFaceEmbeddingEncoder needs to implement a trivial .initialize() method.

[mattseddon]

Can someone please take a look at this?

[rbiseck3]

@mattseddon all the embedder code was actually migrated to the new ingest repo, and this is no longer an issue there: unstructured_ingest/embed/interfaces.py. This code should be emitting a deprecation warning at the moment.

[mattseddon]

@mattseddon all the embedder code was actually migrated to the new ingest repo, and this is no longer an issue there: unstructured_ingest/embed/interfaces.py. This code should be emitting a deprecation warning at the moment.

I didn't get the deprecation warning because the code won't run without this change and I had to revert to a previous version.

[mattseddon]

One other thing - the encoders have different function signatures (list[dict] vs list[Element]):

https://github.com/mattseddon/unstructured/blob/df156ebe5ac4427ec7e2541e99cabb032801721d/unstructured/embed/huggingface.py#L54-L59

https://github.com/Unstructured-IO/unstructured-ingest/blob/e041b865b205358502e5d7f216d75b47219005ca/unstructured_ingest/embed/huggingface.py#L49-L52