-
Notifications
You must be signed in to change notification settings - Fork 909
build(deps): split up dependencies by document type #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructured into build/optional-deps
…ructured into build/optional-deps
…ructured into build/optional-deps
The pattern looks good to me. Hoping to merge #997 ahead of this to get the field name change released first. |
qued
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few comments and suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #611. Updates the dependencies to create a slim base installation + extras for each document type. The
all-docs
extra includes the dependencies for all doc types. Thelocal-inference
extra still remains as an alias forall-docs
since that's the extra many currently users use to install all of the dependencies.As a follow on, the PDF and image requirements could be broken down further by strategy.
Testing
make install-base
andpip install -r requirements/test.txt
andpip install -e .
. The following tests should pass:pytest test_unstructured/partition/test_text.py
pytest test_unstructured/partition/test_email.py
pytest test_unstructured/partition/test_html_partition.py
pytest test_unstructured/partition/test_text.py
pytest test_unstructured/partition/test_xml_partition.py
make install-csv
. The following tests should pass:pytest test_unstructured/partition/test_csv.py
pytest test_unstructured/partition/test_tsv.py
make install-docx
. The following tests should pass:pytest test_unstructured/partition/test_doc.py
pytest test_unstructured/partition/test_docx.py
make install-odt
. The following tests should pass:pytest test_unstructured/partition/test_odt.py
make install-pypandoc
. The following tests should pass:pytest test_unstructured/partition/test_epub.py
pytest test_unstructured/partition/test_org.py
pytest test_unstructured/partition/test_rst.py
pytest test_unstructured/partition/test_rtf.py
make install-markdown
. The following tests should pass:pytest test_unstructured/partition/test_md.py
make install-msg
. The following tests should pass:pytest test_unstructured/partition/test_msg.py
make install-pdf-image
. The following tests should pass:pytest test_unstructured/partition/test_pdf.py
pytest test_unstructured/partition/test_image.py
make install-pptx
. The following tests should pass:pytest test_unstructured/partition/test_ppt.py
pytest test_unstructured/partition/test_pptx.py
make install-xlsx
. The following tests should pass:pytest test_unstructured/partition/test_xlsx.py
make install-ci
andpip install argilla weaviate-client
.make test
should passTest
test_unstructured/partition/test_json.py
is currently a little weird because there are tests in there that usepartition
, making it hard to testpartition_json
isolation. I opened #993 to address that.