-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename updater2 to updater #63
base: master
Are you sure you want to change the base?
Conversation
Do we really have to? I'm sure it will break something... |
Renaming at some point seems like a good idea, but we should take the opportunity to pick something more descriptive than |
The idea of For the distributed file, I would recommend calling it “Unvanquished Updater” (or just “Unvanquished”, but this would raise the bar very high about how much polished the experience must be). Currently, the mac updater is distributed as For example at 0.51.1 time I uploaded on IndieDB one single zip containing |
OK, naming it |
ping |
I have changed my mind about this. The executable basename by itself is what you often see in stuff like |
Related to: This also relates with another talk I had in the past, suggesting the updater would just be named “Unvanquished.exe”, considering the engine is just a file like the nexe or the dpk. [Edit: LOL, this is my comment right above] “UnvanquishedLauncher.exe” would works too. |
I wouldn't call the updater unvanquished.exe because that's not the process open 99% of the time that you're playing. The honor of being renamed to |
Another good reason that the updater name should include "Unvanquished"-- if you use the URL protocol handler in Chrome or Firefox, it asks if you want to open the link with "updater.exe". |
This change has nothing to do with the actual release name right? I think our release name should remain |
Another good reason why “UnvanquishedLauncher“ is better than “UnvanquishedUpdater”. “Unvanquished“ is also better than “UnvanquishedUpdater” on that topic. |
UnvanquishedLauncher sgtm |
The
updater2
name makes no sense in two ways:The repository was already renamed anyway.
We may also want to store the updater as
~/.local/share/unvanquished/base/updater
or something like that (see #50).Docker seems to be broken (I mean docker, not the docker file) on my end so I didn't tested it.