Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spucsvi welcome message #62

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Spucsvi welcome message #62

merged 2 commits into from
Oct 22, 2024

Conversation

fherreazcue
Copy link
Collaborator

I was getting a print per worker... couldn't fix it, so went for using a single worker... feel free to fix and merge if you can think of another way...

@fherreazcue fherreazcue linked an issue Oct 21, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 21, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/UoMResearchIT/docker-introduction/compare/md-outputs..md-outputs-PR-62

The following changes were observed in the rendered markdown documents:


What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-21 19:35:17 +0000

github-actions bot pushed a commit that referenced this pull request Oct 21, 2024
@OliverWoolland
Copy link
Collaborator

Hmm well it's not a true production deployment so single worker probably fine!

Personally I kinda like the prints per worker...

@OliverWoolland OliverWoolland merged commit 765bccd into main Oct 22, 2024
5 checks passed
@fherreazcue fherreazcue deleted the spucsvi-welcome-message branch October 22, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we print something when SPUCSVi ready?
2 participants