068 team member modal #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvonneLiew
requested changes
Aug 20, 2024
Oculux314
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
@jessicazeng13 Deiza's on holiday so I'll jump on this review - it looks great!
I have a suspicion about this image import actually - but will leave till later to check it out properly, for now happy to merge this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes 068 team member modal
What Changed?
Minor styling changes, changed current reach implementation to next syntax + debugging. Couldn't get the photo to show up though, so we hardcoded the image url.
How To Review
Just the Team.tsx file, I kept the old implementation as a comment in one of the instances of images.
Notes
Hardcoded the image, something about the activeMember.Photo attribute is broken. Need to fix at a later stage.