110 projects page timeline component #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Wanted to have a vertical timeline to put on the projects page, that matches the Figma design.
Closes #110
What Changed?
Changed file /test/projects_timeline/page.tsx, and created two new components - DateBlob (which contains that section of the timeline line as well as the date joined onto it) and Timeline (which wraps all DateBlob elements as well as adding dots either end of line).
How To Review
go to /test/projects_timeline and check that the timeline shows up on the LHS, with alternating blob lengths. Also check that it looks good for various screen sizes. Check that repo styling is ok (two components, where one is wrapped inside of the other).
Notes
Accidentally swapped - and _ in branch name, it is 110-projects_page_timeline_component
Have not implemented the alternating/not alternating for current/past projects.
Date formatting is not done, as this is being passed in from Figma anyways.