-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
064 scrollable carousel #144
Conversation
Bug: whole page scrolls with it.
Fixes the body scrolling issue but looks ugly.
This avoid us having to use overflow-hidden which makes the sidebar disappear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! I love that we can see the projects on the home page now 😍
Added a commit - just a few codestyle changes (removing console.logs and unused imports and stuff).
Here's some stylistic feedback:
This is what the carousel looks like on my computer and you can see long images get quite stretched - would you be able to make them cropped instead? Maybe use cover or smth
Also, idk if it's just my browser but the blue text is juuust a tad too big, would you be able to make it smaller? And don't forget to use tailwind to put the ellipsis at the end of the text if there's too much
Finally, to see active projects you just gotta make some projects with a date in 2024 in Strapi :)
Looking great, we're online in Discord if you wanna join!
…younite-web into 064_scrollable-carousel
Hey this is working on prod now (turns out it was just a broken import haha), just wanted to say it looks awesome GJ :) |
Context
Changing up the carousel on the home page to provide a better user experience, including scroll-ability using the mouse wheel, and additional functionality like displaying active projects, redirecting to a project modal and allowing user to see all projects.
Closes #64
What Changed?
How To Review
Notes
The carousel currently shows past projects (even though the intention was to show active ones) and redirects to past projects page - this is because there is no active project data as of yet. Should this need to be changed in the future, uncomment the code tagged with "Uncomment here" on home page, and change see more button link to redirect to active instead of past in CarouselBase file.