Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

064 scrollable carousel #144

Merged
merged 28 commits into from
Oct 21, 2024
Merged

064 scrollable carousel #144

merged 28 commits into from
Oct 21, 2024

Conversation

daisy-of-the-valley
Copy link
Contributor

Context

Changing up the carousel on the home page to provide a better user experience, including scroll-ability using the mouse wheel, and additional functionality like displaying active projects, redirecting to a project modal and allowing user to see all projects.

Closes #64

What Changed?

  • Made carousel scrollable using mouse wheel
  • Modifying the project cards to query data from strapi
  • Changing up project card styling
  • Functionality to redirect to corresponding projects modal when project card is clicked
  • Added "See More" button to direct to projects page

How To Review

  • Carousel scrolls using mouse wheel
  • All project cards are clickable and lead to associated project modal
  • See more button works as intended

Notes

The carousel currently shows past projects (even though the intention was to show active ones) and redirects to past projects page - this is because there is no active project data as of yet. Should this need to be changed in the future, uncomment the code tagged with "Uncomment here" on home page, and change see more button link to redirect to active instead of past in CarouselBase file.

Copy link
Contributor

@Oculux314 Oculux314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! I love that we can see the projects on the home page now 😍
Added a commit - just a few codestyle changes (removing console.logs and unused imports and stuff).

Here's some stylistic feedback:
image
This is what the carousel looks like on my computer and you can see long images get quite stretched - would you be able to make them cropped instead? Maybe use cover or smth
Also, idk if it's just my browser but the blue text is juuust a tad too big, would you be able to make it smaller? And don't forget to use tailwind to put the ellipsis at the end of the text if there's too much
image

Finally, to see active projects you just gotta make some projects with a date in 2024 in Strapi :)
Looking great, we're online in Discord if you wanna join!

@daisy-of-the-valley daisy-of-the-valley merged commit f4eec56 into main Oct 21, 2024
@Oculux314 Oculux314 deleted the 064_scrollable-carousel branch November 3, 2024 00:00
@Oculux314
Copy link
Contributor

Hey this is working on prod now (turns out it was just a broken import haha), just wanted to say it looks awesome GJ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollable Carousel
2 participants