Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

059 Jess Component #89

Merged
merged 2 commits into from
Jul 28, 2024
Merged

059 Jess Component #89

merged 2 commits into from
Jul 28, 2024

Conversation

jessicazeng13
Copy link
Contributor

Context

Closes #59

What Changed?

Added Jess component

How To Review

Notes

Copy link
Contributor

@belleyong belleyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Copy link
Contributor

@Oculux314 Oculux314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jess!!! 🎉

Component looks good, just a few extra changes you might not be aware of that I'll ask you to revert first:

  • .vscode/settings.json
  • next/util/strapi.ts

(check out Files changed tab in PR)

@jessicazeng13 jessicazeng13 requested a review from Oculux314 July 28, 2024 05:46
Copy link
Contributor

@Oculux314 Oculux314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Feel free to merge

@jessicazeng13 jessicazeng13 merged commit ebfcfb8 into main Jul 28, 2024
@jessicazeng13 jessicazeng13 deleted the 059_jess-component branch July 28, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jessica Component
3 participants