Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create spanish translation #118

Open
wants to merge 1 commit into
base: 1.21
Choose a base branch
from
Open

Conversation

Witixin1512
Copy link

No description provided.

Copy link
Contributor

@EnnuiL EnnuiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While Spanish is not a language I'm good at, what I am good at is my own native language (Portuguese :p), so I'm able to review this more properly;

From what I see? It looks good! There's only a minor problem that I notice often with Portuguese translations that I think could be fixed here:
So, while the English text on the game has a tendency to have specific names Capitalized Like This (ex: Diamond Block, Light Blue Wool), its translations can diverge from that; For instance, Brazilian Portuguese only capitalizes the first word (ex: Bloco de diamante, Lã azul-clara), and tends to avoid capitalizing words unless they have a reason to (such as for english words such as Nether or End, and other cases);

Minecraft Examples

A screenshot of Minecraft's key binds menu, translated to Brazilian Portuguese. The vanilla movements category is on focus.

A screenshot of Minecraft's accessibility options screen, translated to Brazilian Portuguese

As a consequence of this, the Brazilian Portuguese translation of Ok Zoomer tries its best to at least fit on that capitalization standard, so it doesn't look too different from anything in the game:

Ok Zoomer Examples

A screenshot of Minecraft's key binds menu, translated to Brazilian Portuguese. The mod-added zoom category is on focus.
A screenshot of Ok Zoomer's configuration screen, translated to Brazilian Portuguese

I've discussed this with someone familiar with the language, and the conclusion was that yeah, this issue does affect Spanish translations too (I've double-checked in-game as well :p)

So, what you consider is:

  • The translation looks good! It's only this tiny issue that is a problem; tackle that, and I'll approve this PR and merge it right away! :p
  • My advice is:
    • Compare your translation with the game's! See if the capitalization is consistent on places where Vanilla and modded are mixed!
    • Really, that's all I can say! The game itself is your best reference on how things should be done; you can disagree with it on few spots! Just don't disagree too hard to the point where the modded thing feels too different from the game :p
    • Language Reload is a pretty neat mod and I recommend it for translation shenanigans
  • Oh, and do note: the wording isn't a problem here, it's really about how words are capitalized (compared to the game)

Yeah, that's all I have to say (for someone who usually can't say too much about a translation lmao)

@UpcraftLP
Copy link
Contributor

Thank you for this, much appreciated! 💜

I'll merge it once @EnnuiL's concerns are addressed ^^

@UpcraftLP UpcraftLP changed the base branch from 1.21 to 1.21.2 November 5, 2024 15:54
@UpcraftLP UpcraftLP changed the base branch from 1.21.2 to 1.21 November 5, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants