Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory support for labels, server groups, server metadata and public/private IP addresses. #16

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

ajmyyra
Copy link
Member

@ajmyyra ajmyyra commented Sep 18, 2023

This PR brings in following updates:

  • Servers without matching interface (connect_with that is public_ipv4 by default) are skipped so other servers can be accessed. Skipped ones are logged.
  • Support for filtering with server labels
  • Support for filtering with server group

@ajmyyra ajmyyra requested a review from a team as a code owner September 18, 2023 12:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #16 (922044e) into main (71bbd1b) will decrease coverage by 6.67%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   52.48%   45.81%   -6.67%     
==========================================
  Files           2        2              
  Lines         181      251      +70     
  Branches       34       53      +19     
==========================================
+ Hits           95      115      +20     
- Misses         77      121      +44     
- Partials        9       15       +6     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ajmyyra ajmyyra changed the title WIP: Inventory support for labels, server metadata and public/private IP addresses. Inventory support for labels, server groups, server metadata and public/private IP addresses. Sep 21, 2023
plugins/inventory/upcloud.py Outdated Show resolved Hide resolved
Copy link
Member

@Darep Darep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test the code & I'm no expert with ansible-inventory, but changes LGTM!

@ajmyyra
Copy link
Member Author

ajmyyra commented Sep 25, 2023

Added some tests to make sure filtering will keep working in the future as well.

@ajmyyra ajmyyra merged commit a0f8103 into main Sep 25, 2023
8 checks passed
@ajmyyra ajmyyra deleted the feat/labels-metadata-and-private-addresses branch September 25, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants