-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing main & dev #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the reference of "DotNetNuke" from the local file to a NuGet.org repository. And I removed an unnecessary EntityFramework reference.
Update Upendo.Modules.UserManager.csproj
Tasks/1.0 release prep
Tasks/update templates
Resolved bugs in issue templates
I created a Solution Structure and moved all the management module files to the Solution Modules folder.
I created a Solution Structure Upendo-Dnn-UserManager.
Tasks/release prep
Updated remaining DNN references to 9.9.0
Page to redirect in case the user is not authenticated, with the personalized message.
Add Error page to redirect in case the user is not authenticated, with a custom message.
Added the logic to redirect to the Error page in case the user is not authenticated.
Added the logic to redirect to the Error page in case the user is not authenticated.
Localization File for UserManager Create and Edit Views
Fixed a silly typo
Instruction updates
Update README.md
Added text labels for Role Status selection.
Added required 'Edit User' and 'Update Successful' resource entries in the FeatureController method.
Added resource entries for 'Approved', 'Disabled', and 'Pending' text labels. To return the list of User Roles Status.
Implemented the module update logic to create the custom module permissions.
Improved role management functionality, adding Role Status management. Additional permission checks and improved code structure.
I changed the use of the API/PersonBar to the UserController class. Fixed security issues, added permission checks, and improved code structure.
Updated user model with additional properties
Added localization files
Implemented methods for user management, including the ListOfUsers method for listing and filtering users, as well as the inclusion of the HasPermission function.
A StatusList method was included to return the list of the Roles' Status, the Create and Edit were updated to save the Status of the role.
Added an additional int portalId parameter to the GetUsers(pagination) method to indicate the portal ID. In the change section within this method, various filter cases were handled, including "Unauthorized", "Deleted", "Superusers", and "Everyone". Each case retrieves the corresponding list of users according to the filter and the portal. Added a total pages calculation using Math.Ceiling(usersTotal / pagination.Take) to ensure accurate page calculations. In the EditUser method, the IsSuperUser value assignment has been adjusted to update only if the current user is a SuperUser. Ternary operators were used to check if the current user is a superuser and assign the appropriate values to IsSuperUser and IsDeleted in the EditUser method.
Added to display a dropdown list for selecting the role's status.
Added to display a dropdown list for selecting the role's status.
Added a JavaScript event listener to disable various form elements if the user is viewing their own profile (ownProfile), ensuring they don't take any action when clicked. And it was validated that the user that is not SuperUser cannot promote another user to that Role.
The pagination parameters were adjusted. Added CSS class superuser checkbox to "IsSuperUser" checkbox (chkIsSuperuser). Introduced JavaScript code to disable the "IsSuperUser" checkbox based on the user's superuser status (isCurrentUserSuperUser). And the values of the filters were changed to be able to use them with the new method implemented using the UserController class.
Changed the name of the permission column
user-workflow-usability
Added the logic to prevent non-admin/superuser users from adding the 'Administrators' role. The view displays user details and their roles without allowing changes.
Added logic to prevent users who are not administrators or superusers from seeing the "Administrators" role listed. The view shows all roles except "Administrators", so the user cannot promote or remove another user from this role.
Security update
Thought I was going to need to do more.
Added an icon to the readme
WillStrohl
added a commit
that referenced
this pull request
Aug 16, 2023
Merge pull request #61 from UpendoVentures/dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing main & dev