Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.9 this.$bindToContext not working #1309

Closed
sean-stanley opened this issue Mar 31, 2016 · 3 comments
Closed

1.3.9 this.$bindToContext not working #1309

sean-stanley opened this issue Mar 31, 2016 · 3 comments

Comments

@sean-stanley
Copy link

Hi,

FYI callbacks wrapped in this.$bindToContext return undefined so the callback is never executed. This is probably related to an issue I raised in Angular Meteor Auth. This is after upgrading to 1.3.9 (still on Meteor 1.2).

I hope this is a quick fix and there will be a patch soon. In the meantime, I'm wrapping my callbacks in a $scope.$apply() to avoid nasty things happening when I run the callback outside of a digest cycle.

@sean-stanley sean-stanley changed the title 1.3.9 this.bindToContext not working 1.3.9 this.$bindToContext not working Mar 31, 2016
@itaibs
Copy link

itaibs commented Apr 6, 2016

Having the same issue after updating to Meteor 1.3.

Posted question on stack overflow as well.

DAB0mB added a commit to DAB0mB/angular-meteor that referenced this issue Apr 7, 2016
DAB0mB added a commit to DAB0mB/angular-meteor that referenced this issue Apr 7, 2016
DAB0mB added a commit to DAB0mB/angular-meteor that referenced this issue Apr 8, 2016
Urigo added a commit that referenced this issue Apr 8, 2016
fix(#1309): Scope.bindToContext() will be applied on scope if no cont…
@Urigo
Copy link
Owner

Urigo commented Apr 10, 2016

Can you try 1.3.10-rc.0 to see if it solves the problem?

@itaibs
Copy link

itaibs commented Apr 11, 2016

So far seems to be working for me!

Thanks!

@Urigo Urigo closed this as completed Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants