Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build project, typescript fails, wrongly defined dependencies on ts/graphqljs/other libs? #1522

Closed
tomasstrejcek opened this issue Mar 22, 2022 · 2 comments

Comments

@tomasstrejcek
Copy link

tomasstrejcek commented Mar 22, 2022

There is possibly bug in dependencis if I can install this and then if fails during compilation, right?

v1.14.1 build fine, but i can't seem to find any changelog or something to find out what are the upgrade steps, reasons for BC in minor version etc :(

example errors:
node_modules/graphql-scalars/scalars/AccountNumber.d.ts:3:44 - error TS2315: Type 'GraphQLScalarType' is not generic.

3 export declare const GraphQLAccountNumber: GraphQLScalarType<string, string>;

node_modules/graphql-scalars/scalars/RoutingNumber.d.ts:3:44 - error TS2315: Type 'GraphQLScalarType' is not generic.

3 export declare const GraphQLRoutingNumber: GraphQLScalarType<string, string>;

Environment:

  • OS: MacOS m1
  • GraphQL Scalars Version: v 1.15.0
  • NodeJS: 16.7.0
  • typescript 4.5.2
  • graphql 15.6.1
@ardatan
Copy link
Collaborator

ardatan commented Mar 23, 2022

We don't have any dependency except tslib(just a small helper library).
It seems it is just mismatching types for v15. I'm checking it now.

@tomasstrejcek tomasstrejcek changed the title Can't build project, typescript fails, wrongly defined dependencies on ts/gryphqljs/other libs? Can't build project, typescript fails, wrongly defined dependencies on ts/graphqljs/other libs? Mar 23, 2022
@ardatan ardatan closed this as completed Mar 24, 2022
@ardatan
Copy link
Collaborator

ardatan commented Mar 24, 2022

Fixed in the latest release. Please let us know if it still fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants