Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with GraphQL v15 & Typescript #2105

Open
4 tasks
Lexicality opened this issue Aug 30, 2023 · 4 comments
Open
4 tasks

Incompatible with GraphQL v15 & Typescript #2105

Lexicality opened this issue Aug 30, 2023 · 4 comments

Comments

@Lexicality
Copy link

Issue workflow progress

Progress of the issue based on the Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

Make sure to fork this template and run yarn generate in the terminal.

Please make sure the GraphQL Scalars package version under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

Same as #1522 and #1195

node_modules/graphql-scalars/typings/scalars/iso-date/Time.d.ts:10:35 - error TS2315: Type 'GraphQLScalarType' is not generic.

10 export declare const GraphQLTime: GraphQLScalarType<Date, string>;
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

To Reproduce
Steps to reproduce the behavior:

  • Install into a project using GraphQL 15
  • Run npx tsc

Expected behavior

Typescript successfully builds

Environment:

  • OS: Ubuntu
  • GraphQL Scalars Version: v1.22.2
  • GraphQL Version: v15.8.0
  • Typescript version: v5.1.6
  • NodeJS: v18.17.0

Additional context

@acomito
Copy link

acomito commented Oct 1, 2023

@Lexicality did you ever fix this?

What combo worked for you?

@Lexicality
Copy link
Author

@Lexicality did you ever fix this?

What combo worked for you?

Nope! I simply gave up and used a variety of other libraries and my own code

@mmmulani
Copy link

seems like you need graphQL version 16: graphql/graphql-js@4f21cdc

breaking change from graphql-scalars that takes advantage of it: 0fb119a

downgrading to graphql-scalars@1.21.3 fixes this

@Lexicality
Copy link
Author

In that case it would be nice if the peer dependencies were updated to make that clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants