Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand DID regex to accommodate did:pkh #1800

Closed
mcclurejt opened this issue Feb 8, 2023 · 1 comment
Closed

Expand DID regex to accommodate did:pkh #1800

mcclurejt opened this issue Feb 8, 2023 · 1 comment

Comments

@mcclurejt
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The current regex for the DID scalar does not match the format for did:pkh which is relatively widely used.

Describe the solution you'd like

Expand the regex to match did:pkh strings.

Describe alternatives you've considered

Creating a separate scalar seems unnecessary

Additional context
@mcclurejt mcclurejt mentioned this issue Feb 8, 2023
Merged
9 tasks
@ardatan
Copy link
Collaborator

ardatan commented Mar 24, 2023

Available in the latest release! Thanks!
#1860

@ardatan ardatan closed this as completed Mar 24, 2023
@theguild-bot theguild-bot mentioned this issue Apr 24, 2023
Open
37 tasks
@theguild-bot theguild-bot mentioned this issue Oct 26, 2023
Open
36 tasks
@theguild-bot theguild-bot mentioned this issue Feb 5, 2024
Open
36 tasks
This was referenced May 2, 2024
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcclurejt @ardatan